schedule: add check action when poll the opeators from opNotifierQueue #8010

TonsnakeLin · 2024-04-01T06:43:23Z

What problem does this PR solve?

Issue Number: Close #7992

What is changed and how does it work?

It add light check for polling the opeators from Controller::opNotifierQueue. 
For example, check whether the region has disappeared，check whether the version of region epoch has changed for merge-region operator.
It has the chance to cancel the operators from Controller::opNotifierQueue execept timeout. We can only cancel the operator by timeout mechanism before.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has the configuration change
Has HTTP API interfaces changed (Don't forget to add the declarative for the new API)
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tiup:
Need to cherry-pick to the release branch

Release note

None.

Signed-off-by: TonsnakeLin <[email protected]>

ti-chi-bot · 2024-04-01T06:43:25Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

disksing
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2024-04-01T06:43:32Z

Hi @TonsnakeLin. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: TonsnakeLin <[email protected]>

TonsnakeLin · 2024-04-01T07:10:37Z

/cc @disksing @Connor1996

TonsnakeLin · 2024-04-01T07:57:22Z

/test ?

ti-chi-bot · 2024-04-01T07:57:36Z

@TonsnakeLin: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/schedule/operator/operator_controller.go

rleungx · 2024-04-01T10:05:52Z

pkg/schedule/operator/operator_controller.go

+	// But to be cautions, it only takes effect on merge-region currently.
+	// If the version of epoch is changed, the region has been splitted or merged, and the key range has been changed.
+	// The changing for conf_version of epoch doesn't modify the region key range, skipt it.
+	if (op.Kind()&OpMerge != 0) && region.GetRegionEpoch().GetVersion() != op.RegionEpoch().GetVersion() {


Do we need to compare the epoch like checkStaleOperator?

checkStaleOperator only check the ConfVersion of region epoch which maybe not resolve the issue #7992. For example, "operator add split-region 258 --policy="approximate" will change the version of region 258, but not for ConfVersion.
Another reason is I don't know why limits the checkStaleOperator only to DispatchFromHeartBeat source https://github.com/tikv/pd/blob/master/pkg/schedule/operator/operator_controller.go#L120

Yes, is it enough to only check the version? Or we also need to check both the version and conf version?

At begining, I checked both the version and conf-version. But I think the conf-version changed doesn't mean the key-range changed, the merge operator can still be executed sucessfully. At last I check only the version of RegionEpoch.
um... I'm a little not sure whether to consider conf-version.
Could you give me some suggestion ? @disksing @rleungx , Thank you!!

BTW, I think there will be a problem if we use != since the operator's epoch won't change after creating.

rleungx · 2024-04-01T10:45:34Z

/ok-to-test

Signed-off-by: TonsnakeLin <[email protected]>

codecov · 2024-04-01T13:41:25Z

Codecov Report

Merging #8010 (00cfdaf) into master (6fe44d7) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 00cfdaf differs from pull request most recent head 6da6e25. Consider uploading reports for the commit 6da6e25 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8010      +/-   ##
==========================================
- Coverage   73.60%   73.57%   -0.03%     
==========================================
  Files         436      436              
  Lines       48516    48512       -4     
==========================================
- Hits        35709    35694      -15     
- Misses       9743     9755      +12     
+ Partials     3064     3063       -1

Flag	Coverage Δ
unittests	`73.57% <100.00%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: TonsnakeLin <[email protected]>

rleungx · 2024-04-03T02:50:17Z

/merge

ti-chi-bot · 2024-04-03T02:50:19Z

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-04-03T02:50:20Z

This pull request has been accepted and is ready to merge.

Commit hash: 00cfdaf

close tikv#7992 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2024-04-15T06:16:57Z

In response to a cherrypick label: new pull request created to branch release-7.1: #8066.

ti-chi-bot · 2024-05-07T05:51:28Z

In response to a cherrypick label: new pull request could not be created: failed to create pull request against tikv/pd#release-7.5 from head ti-chi-bot:cherry-pick-8010-to-release-7.5: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID 98EE:21F144:5006CCD:80D2AFD:6639C15F and timestamp 2024-05-07 05:51:28 UTC.","documentation_url":"https://docs.github.com/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits"}

close tikv#7992 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2024-05-13T12:44:16Z

In response to a cherrypick label: new pull request created to branch release-6.5: #8170.

TonsnakeLin · 2024-05-15T09:38:35Z

/cherry-pick release-7.5

ti-chi-bot · 2024-05-15T09:39:12Z

@TonsnakeLin: new pull request created to branch release-7.5: #8179.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

#8010) (#8179) close #7992 Signed-off-by: TonsnakeLin <[email protected]> Co-authored-by: TonsnakeLin <[email protected]>

add check action when poll the opeators from opNotifierQueue

0d3e22f

Signed-off-by: TonsnakeLin <[email protected]>

ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 1, 2024

ti-chi-bot bot requested review from lhy1024 and rleungx April 1, 2024 06:43

ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2024

update

4c66076

Signed-off-by: TonsnakeLin <[email protected]>

ti-chi-bot bot requested review from Connor1996 and disksing April 1, 2024 07:10

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Apr 1, 2024

disksing approved these changes Apr 1, 2024

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2024

rleungx reviewed Apr 1, 2024

View reviewed changes

ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 1, 2024

update

86698bd

Signed-off-by: TonsnakeLin <[email protected]>

TonsnakeLin added 2 commits April 1, 2024 21:57

add test case

bd153b2

Signed-off-by: TonsnakeLin <[email protected]>

change the cmp method from ne to gt.

00cfdaf

Signed-off-by: TonsnakeLin <[email protected]>

rleungx approved these changes Apr 2, 2024

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 2, 2024

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 3, 2024

Merge branch 'master' into lp-fix-7992

6da6e25

ti-chi-bot bot merged commit a2b0e3c into tikv:master Apr 3, 2024
22 checks passed

ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Apr 15, 2024

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Apr 15, 2024

This is an automated cherry-pick of tikv#8010

07010d5

close tikv#7992 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Apr 15, 2024

schedule: add check action when poll the opeators from opNotifierQueue (#8010) #8066

Closed

ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 7, 2024

ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label May 13, 2024

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request May 13, 2024

This is an automated cherry-pick of tikv#8010

1558840

close tikv#7992 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request May 13, 2024

schedule: add check action when poll the opeators from opNotifierQueue (#8010) #8170

Closed

TonsnakeLin deleted the lp-fix-7992 branch May 15, 2024 09:01

ti-chi-bot mentioned this pull request May 15, 2024

schedule: add check action when poll the opeators from opNotifierQueue (#8010) #8179

Merged

ti-chi-bot bot pushed a commit that referenced this pull request May 20, 2024

schedule: add check action when poll the opeators from opNotifierQueue (

5a3d21d

#8010) (#8179) close #7992 Signed-off-by: TonsnakeLin <[email protected]> Co-authored-by: TonsnakeLin <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

schedule: add check action when poll the opeators from opNotifierQueue #8010

schedule: add check action when poll the opeators from opNotifierQueue #8010

TonsnakeLin commented Apr 1, 2024

ti-chi-bot bot commented Apr 1, 2024 •

edited

Loading

ti-chi-bot bot commented Apr 1, 2024

TonsnakeLin commented Apr 1, 2024

TonsnakeLin commented Apr 1, 2024

ti-chi-bot bot commented Apr 1, 2024

rleungx Apr 1, 2024

TonsnakeLin Apr 1, 2024

rleungx Apr 2, 2024 •

edited

Loading

TonsnakeLin Apr 2, 2024 •

edited

Loading

rleungx Apr 2, 2024

rleungx commented Apr 1, 2024

codecov bot commented Apr 1, 2024 •

edited

Loading

rleungx commented Apr 3, 2024

ti-chi-bot bot commented Apr 3, 2024

ti-chi-bot bot commented Apr 3, 2024

ti-chi-bot commented Apr 15, 2024

ti-chi-bot commented May 7, 2024

ti-chi-bot commented May 13, 2024

TonsnakeLin commented May 15, 2024

ti-chi-bot commented May 15, 2024

schedule: add check action when poll the opeators from opNotifierQueue #8010

schedule: add check action when poll the opeators from opNotifierQueue #8010

Conversation

TonsnakeLin commented Apr 1, 2024

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Apr 1, 2024 • edited Loading

ti-chi-bot bot commented Apr 1, 2024

TonsnakeLin commented Apr 1, 2024

TonsnakeLin commented Apr 1, 2024

ti-chi-bot bot commented Apr 1, 2024

rleungx Apr 1, 2024

Choose a reason for hiding this comment

TonsnakeLin Apr 1, 2024

Choose a reason for hiding this comment

rleungx Apr 2, 2024 • edited Loading

Choose a reason for hiding this comment

TonsnakeLin Apr 2, 2024 • edited Loading

Choose a reason for hiding this comment

rleungx Apr 2, 2024

Choose a reason for hiding this comment

rleungx commented Apr 1, 2024

codecov bot commented Apr 1, 2024 • edited Loading

Codecov Report

rleungx commented Apr 3, 2024

ti-chi-bot bot commented Apr 3, 2024

ti-chi-bot bot commented Apr 3, 2024

ti-chi-bot commented Apr 15, 2024

ti-chi-bot commented May 7, 2024

ti-chi-bot commented May 13, 2024

TonsnakeLin commented May 15, 2024

ti-chi-bot commented May 15, 2024

ti-chi-bot bot commented Apr 1, 2024 •

edited

Loading

rleungx Apr 2, 2024 •

edited

Loading

TonsnakeLin Apr 2, 2024 •

edited

Loading

codecov bot commented Apr 1, 2024 •

edited

Loading